emscripten-core/emscripten

Cryptic `sig is undefined` error in reportUndefinedSymbols() if function signature not available

Open

#17,283 建立於 2022年6月21日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C++ (27,361 star) (3,519 fork)batch import
good first bughelp wanted

描述

Discussed in https://github.com/emscripten-core/emscripten/discussions/17266

Originally posted by johnwason June 18, 2022 Currently if a function signature is not defined, reportUndefinedSymbols() will simple raise an error sig is undefined, which is not at all helpful. An error handler should be added to check if the value passed to addFunction() does not have sig defined, and report something more useful to the user. See #17264

貢獻者指南

技術棧
ccppjavascriptwasm
領域
backendtoolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaScriptEmscripten basics
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Locate the `reportUndefinedSymbols()` function in Emscripten's JavaScript runtime code. The function currently raises a cryptic 'sig is undefined' error when a function signature is not provided. Review the related discussion (#17266) and issue (#17264) for background. Add a check to verify that `sig` is defined before using it, and provide a more informative error message indicating which function lacks a signature. The fix is likely in a single file within the Emscripten source tree.