emberjs/ember.js

Unreachable code "reached" when trying to render a non-string with the component helper

Open

#18,072 建立於 2019年6月4日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)JavaScript (22,437 star) (4,216 fork)batch import
BugGood for New ContributorsHas ReproductionHelp Wanted

描述

Ember Twiddle

Ember Twiddle doesn't let me go above 3.4, but I'm reproducing this on a 3.10 app (during a migration from 2.18).

This is less of a bug and more of something that could have a helpful debug assertion. Maybe something like:

You passed [Object object] to the {{component}} helper, but the component helper only accepts strings or other components.

Along with maybe a log of what that object was.

(This might not be the right repo for this, since it seems to deal with glimmervm internals)

貢獻者指南

技術棧
javascript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic Ember.js knowledgeunderstanding of component helper
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
The issue requests adding a debug assertion when a non string/non component is passed to the {{component}} helper. The relevant code likely resides in ember.js's glimmer packages, specifically the component helper implementation. Look for files in packages/ember glimmer that handle the component helper, such as lib/component.js or similar. The existing error handling for invalid arguments should be located, and a new assertion can be added following Ember's debugging patterns. Check if there are any existing tests for the component helper to ensure the new assertion is covered.