emberjs/ember-test-helpers

Input events should be instantiated with `{ composed: true }`

開放

#1,201 建立於 2022年3月3日

 (2 則留言) (1 個反應) (0 位負責人)JavaScript (256 個分叉)github user discovery
enhancementgood first issue

倉庫指標

星標
 (188 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

The composed property determines whether an event that occurs in shadow DOM will bubble to the host element.

Link to MDN docs.

In HTML, all form control input events are composed 1 2.

Presently, we are not instantiating input events with { composed: true }. See for example fillIn and select. I have not looked if there are other places. It probably makes sense to make this change in fireEvent itself similar to how bubbles is true by default.

Footnotes

  1. Search for "Fire an event named input" on https://html.spec.whatwg.org/multipage/input.html and https://html.spec.whatwg.org/multipage/form-elements.html.

  2. Change events are not composed.

貢獻者指南