ember-fastboot/ember-cli-fastboot

Figure out why some tests need application-template-wrapper enabled to pass

Open

#838 建立於 2021年6月21日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)JavaScript (853 star) (163 fork)batch import
Good for New Contributorsgood first issuetest

描述

As part of my work to upgrade ember-cli-fastboot using ember-cli-update I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in this commit and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

貢獻者指南

技術棧
javascript
領域
testing
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Ember.jsFastBootTesting with QUnit
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
35
研究方向
First, revert the commit mentioned (b7c3934) to see which tests fail. Then examine the test selectors that may rely on the application template wrapper div. Look for tests that use selectors like '#ember testing' or similar. Check if the failing tests can be fixed by updating selectors or by enabling the wrapper. Report findings in the issue.