ember-fastboot/ember-cli-fastboot

Figure out why some tests need application-template-wrapper enabled to pass

開放

#838 建立於 2021年6月21日

 (0 則留言) (0 個反應) (0 位負責人)JavaScript (163 個分叉)batch import
Good for New Contributorsgood first issuetest

倉庫指標

星標
 (853 顆星)
PR 合併指標
 (30 天內沒有已合併 PR)

描述

As part of my work to upgrade ember-cli-fastboot using ember-cli-update I noticed that some tests failed because they needed the application-template-wrapper to be enabled in optitonal-features.

I didn't really have the time to investigate why, and I didn't want to block the other PR any more than it already was 🙈 so this issue is to keep track that it needs to be looked into.

To test this, just undo the work in this commit and see why some tests fail 🤷 I have a feeling it could just be a selector depending on the wrapper div existing 🤔

貢獻者指南