eligrey/FileSaver.js

include TS types in the repo

Open

#540 建立於 2019年4月5日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)JavaScript (21,193 star) (4,366 fork)batch import
enhancementhelp wanted

描述

I know types are available in @types, but it would be nicer if they were part of this package. TS has grown so much that most popular packages include types in their repo.

貢獻者指南

技術棧
typescript
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic TypeScript knowledgeFamiliarity with FileSaver.js API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
This issue requests adding TypeScript type definitions directly to the FileSaver.js repository instead of relying on the separate @types/filesaver package. To implement, one would need to create a declaration file (e.g., index.d.ts) with type annotations for the exported functions like saveAs. Check the existing source code at the repository root and the type definitions from DefinitelyTyped (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/filesaver) for reference. Discuss in the issue about maintaining types alongside the JavaScript source.