electerious/ackee-lighthouse
Add .env property to allow to set more Browser flags
開放
#10 建立於 2021年7月23日
help wanted
倉庫指標
- 星標
- (16 顆星)
- PR 合併指標
- (30 天內沒有已合併 PR)
描述
I used the tool locally and I missed the following feature to set a custom browser path:
const createReports = async (endpoint, headers, events, urls, audit) => {
const additionalBrowserFlags = {};
if (process.env.BROWSER_PATH)
additionalBrowserFlags['chromePath'] = process.env.BROWSER_PATH;
const browser = await chromeLauncher.launch({
chromeFlags: ['--headless'],
...additionalBrowserFlags,
});
...
}
.env file:
...
BROWSER_PATH=C:\\Program Files (x86)\\Microsoft\\Edge\\Application\\msedge.exe
...
A such configuration would allow to test with multiple Chromium based browser like in my case Edge. What do you think? Would that be a proper enhancement?