elastic/logstash

S3 input output plugin might leak passwords

Open

#12,540 建立於 2020年12月30日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)Ruby (14,197 star) (3,496 fork)batch import
good first issue

描述

When you use minio or another S3 provider that uses path_style for buckets and do not configure this with the force_path_style then logstash while fail with a stacktrace which contains the S3 secret key. This was tested with secret key and key identifier present in the config. Not tested with a config file yet. probably config file is better.

貢獻者指南

技術棧
無
領域
backendsecurity
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Logstash basicsS3 configuration
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the S3 input and output plugins' error handling to identify where the secret key is included in stack traces. Look for any existing code that redacts sensitive information. Consider modifying the error logging to exclude the secret key when displaying configuration errors. Review comments in the issue for any additional context.
S3 input output plugin might leak passwords · elastic/logstash#12540 | Good First Issue