elastic/kibana

[Ingest Manager] Update EuiComboBox to render single select options as plain text

Open

#75,005 建立於 2020年8月13日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Team:Fleetgood first issue

描述

There are places in Ingest Manager where we use EuiComboBox but only allow a single option to be selected. In these cases, we've been using the "badge" style like this:

image

EUI allows you to render the option as plain text, like this: image

We should update all of the places where we have this "single select" behavior to use plain text. For example, the "namespace" field shown under advanced settings when creating an Agent config / policy has this. I think this also appears in the Add / edit integration workflow. We should be able to find all the places we do this by searching the Ingest Manager codebase for the singleSelection prop.

See the "Single selection" section in the EUI docs for more information.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactEUIKibana codebase familiarity
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Find all uses of the `singleSelection` prop in the Ingest Manager codebase. Search for `<EuiComboBox singleSelection` in the files under `x pack/plugins/ingest manager/`. For each instance where only one option is selectable, change the `renderOption` prop to use plain text instead of the default badge style. Refer to the EUI documentation on single selection combo boxes for the correct prop to pass. Test that the change works visually and does not break any functionality.