elastic/kibana

[APM] Proposal: Merge error sample and trace summary into a single component

Open

#213,436 建立於 2025年3月6日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Team:obs-ux-infra_services - DEPRECATEDdiscussgood first issuetechnical debt

描述

Trace summary and error sample summary look super similar, and they could be merged into a single component. As a background, we had 2 bugs related to those because of missing fields coming from the queries: if it was a single component, we wouldn't have prevented the bug from happening, but we could have found all usages and would have been easier to fix all places as now they are completely separate. Ref: #213430 and https://github.com/elastic/kibana/pull/206932

👍 :

  • Easier to test
  • Less repeating code
  • Easier to maintain
  • Easier to find similar issues to the above

👎 :

  • Harder to customize and have different data
  • Changes will affect both places (which can be 👍 and 👎 )
  • They are different summaries based on the context, so it might create confusion - good naming is required

⚠ This is just a proposal open for discussion

貢獻者指南

技術棧
typescriptreact
領域
frontenddeveloper experience
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
TypeScriptReactUnderstanding of APM UI components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Start by examining the current trace summary and error sample summary components in the Kibana APM plugin (likely located in packages/plugins/apm). Review the linked pull requests #213430 and #206932 to understand the missing fields bugs. Analyze the similarities and differences in the components' data and usage. Propose a merged component design that maintains customization where needed, and outline testing strategy.