elastic/kibana

[Management] Number fields accept invalid input

Open

#197,506 建立於 2024年10月23日

在 GitHub 查看
 (5 留言) (0 反應) (1 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Team:Kibana Managementbuggood first issue

描述

While testing https://github.com/elastic/kibana/pull/196527, I noticed that different form fields in Kibana Management plugins accept invalid input in number fields. Examples I noticed:

  • Ingest pipelines creation flow - add processor form
  • ILM creation flow

https://github.com/user-attachments/assets/6a883a7b-0cf4-43e2-bc36-c0ff6d2ebf1b

https://github.com/user-attachments/assets/45e21ff4-fc0d-4ef0-89c9-4dc922e1abfe

I think the e, -, and , characters are allowed by the Eui number field itself and it contains some validation for valid numbers. We should probably add validations from our side for valid numbers as well and not allow submitting the form if the number is invalid.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
ReactTypeScriptEui components
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Investigate the Ingest pipelines and ILM creation flows in Kibana Management plugins. Look at the EuiNumberField component's validation behavior. The issue references PR #196527; examine that PR for context. Since the issue has an assignee, coordinate with them before starting work. Focus on adding custom validation in form submission handlers to reject non numeric input.