elastic/kibana

[Telemetry] Better error handling at the `telemetry_plugin_collector`

Open

#122,634 建立於 2022年1月11日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Feature:TelemetryTeam:Coregood first issueimpact:lowloe:small

描述

In the telemetry_plugin_collector we are swallowing any errors thrown by getTelemetrySavedObject: https://github.com/elastic/kibana/blob/c2641bd8cc875dd50c63a40fbaf3054780cd570b/src/plugins/telemetry/server/collectors/telemetry_plugin/telemetry_plugin_collector.ts#L45-L52

I don't think that we should do this as we might report different data depending on whether there's an ES connection issue or not (because when there's no savedObject information we rely on the kibana.yml config values).

IMO, we should either let the collector fail or populate the related fields only when getTelemetrySavedObject succeeds.

貢獻者指南

技術棧
typescriptnodejs
領域
backendobservability
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptNode.jsElasticsearchKibana telemetry
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
The issue is located in `src/plugins/telemetry/server/collectors/telemetry plugin/telemetry plugin collector.ts` around line 45-52, where errors from `getTelemetrySavedObject` are currently swallowed. The two suggested approaches are to either let the collector fail or only populate fields when the call succeeds. A contributor should evaluate which approach is more appropriate for consistent telemetry data and implement the change. No linked PRs or assignees exist, so this is an open opportunity.