elastic/kibana

[APM] Add more info to the "Number of items in this trace exceed what is displayed" (xpack.apm.waterfall.exceedsMax) EuiCallOut

Open

#118,282 建立於 2021年11月11日

在 GitHub 查看
 (10 留言) (0 反應) (0 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Team:obs-ux-infra_services - DEPRECATEDapm:waterfallenhancementgood first issuestale

描述

Kibana version

7.15.1

Steps to Reproduce

  1. set up a separate deployment's kibana to report into APM
  2. pull up a trace for alerting:monitoring_alert_jvm_memory_usage (it's a taskManager run type)
  3. check the trace sample, especially after some time has passed

Expected Behavior

When the number of items exceeds the setting xpack.apm.waterfall.exceedsMax we should display the message:

Number of items in this trace exceed the maximum configured value (100). Please configure xpack.apm.ui.maxTraceItems to increase this value. See docs for more details

Actual Behavior

Get a number of items exceed message like this:

Screen Shot 2021-11-11 at 13 15 56

To work around this I ended up just browsing the kibana code to find the setting (maxTraceItems). Once I had that I was able to google my way to https://www.elastic.co/guide/en/kibana/current/apm-settings-in-kibana.html

Implementation details

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/server/routes/traces/get_trace_items.ts#L77

貢獻者指南

技術棧
typescriptreactnodejs
領域
frontendobservability
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Kibana APM pluginUnderstanding of Kibana configuration settingsAbility to edit TypeScript code
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Locate the file where the callout message is defined, likely in `x pack/plugins/apm/public/components/...` or the server side message constant. Modify the message string to include `xpack.apm.ui.maxTraceItems` and a link to the Kibana APM settings documentation (e.g., https://www.elastic.co/guide/en/kibana/current/apm settings in kibana.html). Test the change locally by triggering the trace item limit and verify the updated callout displays correctly.