elastic/kibana

Edit role page allows you to exit before changes are saved

Open

#106,576 建立於 2021年7月22日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)TypeScript (19,065 star) (8,021 fork)batch import
Team:Securityenhancementgood first issue

描述

Related: #42503

Kibana version: 7.14.0 and earlier

Describe the bug:

Creating (or editing) a role takes several steps:

  • Add ES privileges
  • Add Kibana privileges
  • Click the "Save role" (or "Create role") button

This is particularly easy to overlook when you are adding a Kibana privilege, because there is a filled in "Add Kibana privilege" (or "Update space privilege") button

Steps to reproduce:

  1. Navigate to Stack Management > Roles
  2. Create or edit a role
  3. Change the role and navigate to a different page
  4. Observe that Kibana lets you leave without saving the role

Expected behavior:

  1. The "Add Kibana privilege" (or "Update space privilege") button on the Kibana privileges flyout should be renamed and/or made less prominent (changed to an outline button?); it's too easy to mistake that that actually updates the role when it doesn't. Also, these names should be more similar (perhaps they can both just be "Continue"?)
  2. If changes are detected but not saved, we should probably catch the user before they navigate away from the page. Note that we should make sure session timeout is not negatively impacted.

Screenshots (if relevant):

image

image

貢獻者指南

技術棧
typescriptreact
領域
frontendsecurity
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Kibana basicsTypeScriptReactUI navigation patterns
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Start by exploring the Kibana role management UI, likely in the `x pack/plugins/security` directory. Look for components related to the role editor and the Kibana privileges flyout (files such as `edit role page.tsx` or `kibana privileges flyout.tsx`). The fix involves two parts: first, modify the button label and styling to differentiate it from the save action; second, add a navigation guard using `beforeunload` or React Router's `Prompt` to warn users about unsaved changes. Check existing tests in the same directory for guidance on testing the changes. The issue #42503 may have additional context.
Edit role page allows you to exit before changes are saved · elastic/kibana#106576 | Good First Issue