elastic/elasticsearch

Log all index settings updates at INFO level

開放

#52,871 建立於 2020年2月27日

 (7 則留言) (1 個反應) (0 位負責人)Java (25,882 個分叉)batch import
:Core/Infra/Settings>enhancementTeam:Core/Infrahelp wantedtriaged

倉庫指標

星標
 (76,700 顆星)
PR 合併指標
 (平均合併 2天) (30 天內合併 1,000 個 PR)

描述

Most updates to index settings are handled by a settings update consumer registered via IndexScopedSettings#addSettingsUpdateConsumer. In contrast, the settings defined in IndexMetaData (index.blocks.*, index.priority, etc.) are consumed directly from the Settings object instead. Changes to index settings that are consumed via a settings update consumer result in an INFO-level log message (see e.g. #49969). Changes to directly-consumed settings do not automatically result in any log messages, and we explicitly handle some special cases like index.number_of_replicas elsewhere.

I think this is confusing since from a user's perspective there's no way to distinguish these two classes of index settings. A user seeing that some settings updates are logged may wrongly infer that the lack of logging of other settings updates means that those other settings were not updated.

Should we make this consistent? Consistency is good, but noisier logs are bad.

貢獻者指南