elastic/elasticsearch

Consistency between `_search` and `_msearch`

Open

#4,227 建立於 2013年11月21日

在 GitHub 查看
 (38 留言) (1 反應) (1 負責人)Java (76,700 star) (25,882 fork)batch import
:Search Foundations/Search>bugTeam:Search Foundationsgood first issuehelp wantedpriority:normal

描述

The _msearch API doesn't accept the same header parameters than _search's query parameters. For instance version is both valid in the search body and query parameters for _search, but is ignored in the query parameters and header in _msearch.

MultiSearchRequest.add() should rely on RestSearchAction.parseSearchSource() or even RestSearchAction.parseSearchRequest() to parse the subrequests, for maximum compatibility.

IMHO, a clean bulk API should use the header parameters as query parameters on the target endpoint, which would imply that they keep in sync no matter the code changes in the target endpoints.

貢獻者指南

技術棧
javarest api
領域
apibackend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
over 1 week
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
JavaElasticsearch internalsREST API module
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
15
研究方向
The issue is about ensuring that the msearch API accepts the same header parameters as search's query parameters. The proposed solution is to modify MultiSearchRequest.add() to use RestSearchAction.parseSearchSource() or parseSearchRequest() for parsing subrequests. Start by examining the current implementation of MultiSearchRequest.add() in the Elasticsearch codebase, and study how RestSearchAction handles query parameters like 'version'. Look at the linked comments for discussions on desired behavior. Then implement the changes to delegate parsing accordingly, ensuring backward compatibility.