elastic/elasticsearch-py

Helpers for `bulk` method such as `async_bulk` sleep in blocking manner, preventing graceful shutdown

Open

#2,484 建立於 2024年3月22日

在 GitHub 查看
 (5 留言) (0 反應) (0 負責人)Python (4,060 star) (1,206 fork)batch import
Area: HelpersCategory: Enhancementgood first issue

描述

We tried using async_bulk and async_streaming_bulk helpers to ingest data into Elasticsearch and they work great, but we've found out that they prevent our code from gracefully shutting down when CTRL+C is pressed.

Example code that sleeps: https://github.com/elastic/elasticsearch-py/blob/e1603f4f25888ca7fee03ee977abafb00d512601/elasticsearch/_async/helpers.py#L249-L251

It would be great to have a way to:

  • Either define how the sleep happens by passing sleep function into the client
  • Make Elasticsearch client internally cancel all sleeps when the client is closed

貢獻者指南

技術棧
python
領域
backenddata
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Python async programmingElasticsearch client helpers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
65
研究方向
Examine the helpers.py file at the linked line (L249 L251) to understand the blocking sleep call. Consider implementing one of the proposed solutions: either allow passing a custom sleep function to the helpers, or make the client cancel all in progress sleeps when closed. Review the existing async helpers for bulk operations and test the fix with a simulated shutdown scenario.