eduaguilera/whep

footprint_uncertainty: propagate_fp_uncertainty accepts malformed probs unvalidated

開放

#215 建立於 2026年7月22日

 (1 則留言) (0 個反應) (0 位負責人)R (3 個分叉)auto 404
area:footprintbuggood first issuehelp wantedmechanicalno-data-neededpriority:low

倉庫指標

星標
 (1 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

What

propagate_fp_uncertainty() (R/footprint_uncertainty.R:154-169, 185-195) merges options$probs with no length/range check. probs = c(0.05, 0.95) errors only after all n draws are computed (probs[3] → NA in quantile), and unordered probs silently produce q_low > q_high.

Suggested fix / check

Validate probs (length, range [0,1], ordering) at entry before drawing.


From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.

貢獻者指南