eclipse-theia/theia

Issue with multiple comments with Github Pull request plugin

Open

#9,007 建立於 2021年1月30日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
bughelp wantedvscode

描述

Bug Description:

Start Review and Add comment buttons behaves same across multiple comments dialog

Steps to Reproduce:

  1. Refer the steps given in https://github.com/eclipse-theia/theia/pull/8870
  2. Open a file with multiple changes
  3. Open and add reply in both the discussion
  4. Remove the content from one discussion and notice the buttons of both discussion changes

https://user-images.githubusercontent.com/13016475/106349492-34a98800-62f4-11eb-8c4e-3facc77af18b.mov

Additional Information

  • Theia Version: Version 1.10.0

貢獻者指南

技術棧
typescriptreactnodejs
領域
frontenddeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
basic knowledge of Theiaunderstanding of GitHub pull request plugin
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
The issue describes that the 'Start Review' and 'Add comment' buttons behave the same across multiple comment dialogs. The steps reference PR #8870. To fix, investigate the plugin code likely located in packages/git or plugins/github. Look for event handling that couples button states incorrectly. Check the linked PR for context on recent changes.