eclipse-theia/theia

Use "Broken Icon Reference" when not finding icons from contributions

Open

#8,240 建立於 2020年7月27日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)TypeScript (18,676 star) (2,478 fork)batch import
contributor experienceenhancementgood first issuehelp wanted

描述

Feature Description:

We have cases like this (https://github.com/eclipse-theia/theia/issues/7634) where we can't resolve an icon that is referenced in a contribution. It would be helpful to return an icon that signifies "Icon not found" and display that in the place of the desired icon. Currently, there is no indication in the UI that an icon could not be loaded and where it would be.

貢獻者指南

技術棧
typescriptreact
領域
frontenddeveloper experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Familiarity with Theia's icon contributions
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate icon resolution in Theia's frontend, specifically the icon service (likely in packages/core/src/browser/icon service.ts). Look for where icon contributions are resolved and displayed. Consider adding a fallback icon (e.g., a 'broken' icon class) when a referenced icon cannot be found. Review related issue #7634 for context.