[search-in-workspace] Workspace search does not work in Electron with asar packaging · eclipse-theia/theia#7528

(4 留言) (2 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import

electronelectron-buildhelp wantedsearch in workspace

描述

Description

Workspace search does not work in Electron with asar packaging enabled because rg cannot be spawned. The following message is shown when launching the Electron executable via a console:

process ERROR Error: spawn C:\path\to\application\resources\app.asar\node_modules\vscode-ripgrep\bin\rg.exe ENOENT
    at Process.ChildProcess._handle.onexit (internal/child_process.js:232:19)
    at onErrorNT (internal/child_process.js:407:16)
    at process._tickCallback (internal/process/next_tick.js:63:19)

In the above path, app.asar should be replaced with app.asar.unpacked, as binaries cannot be in the asar file and have to be unpacked instead in order to be executable. However, the rg path (created here and used here) does not take this into account.

See also https://github.com/electron/electron/issues/6262 for a general discussion about this issue.

Reproduction Steps

Enter anything in the workspace search box. No search results are shown.

OS and Theia version: Windows 10 1803, Theia 0.16.1.

Diagnostics: See above.

貢獻者指南

技術棧: typescriptnodejselectron
領域: desktopsearch
議題類型: bug
難度: 2
預計時間: half day
活動狀態: stale
清晰度: clear
前置要求: node.js basicselectron packagingasar file format
新手友善度: 40
研究方向: The issue is that the ripgrep binary is packed inside the asar archive and cannot be executed. The fix involves adjusting the path resolution to use 'app.asar.unpacked' instead of 'app.asar'. Investigate the path construction in 'packages/search in workspace/src/node/search in workspace backend module.ts' and the vscode ripgrep library's index.js (linked in the issue). Also consider using Electron's 'process.resourcesPath' to get the correct resources directory. The electron issue #6262 provides context.