eclipse-theia/theia

better error reporting when a breakpoint cannot be set

Open

#7,499 建立於 2020年4月3日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
bugdapdebughelp wanted

描述

I can see following with debugging https://github.com/TypeFox/leeway project with go vscode extension:

Bug there are better information on returned json response in body.error:

From DAP:

If the value is false, the attribute 'message' contains the error in short form and the 'body' may contain additional information (see 'ErrorResponse.body.error').

I don't think we ever log ErrorResponse.body.error. We should check other places where we handle error responses.

貢獻者指南

技術棧
typescriptgo
領域
developer experience
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptDebug Adapter ProtocolTheia debugger
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
70
研究方向
Search for places in Theia's debug adapter client where DAP error responses are captured. Specifically look for where breakpoint setting occurs and ensure that `ErrorResponse.body.error` is logged in addition to the short message. The DAP spec indicates that `body.error` may contain additional details. Check all error handling paths for DAP responses. See the debug session and debug adapter protocol implementations in the Theia repository.