eclipse-theia/theia

[keybinding][windows] Keybinding collisions

Open

#6,153 建立於 2019年9月10日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
OS/Windowsbughelp wantedkeybindingsterminal

描述

Description

There is a keybinding collision in Theia. Happens on Windows.

root WARN Collided keybinding is ignored;  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}  collided with  {"command":"terminal:clear","keybinding":"ctrlcmd+k","context":"terminalActive"}

root WARN Could not register keybinding:
  {"command":"passthrough","keybinding":"ctrl+k","context":"terminalActive"}
Error: "ctrl+k" is in collision with something else [scope:0]

Reproduction Steps

Start Theia on Windows.

OS and Theia version: Windows a9a39db21 Diagnostics:

貢獻者指南

技術棧
typescript
領域
developer experiencetooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
Understanding of Theia's keybinding systemFamiliarity with Windows key modifiers
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the keybinding registration code in Theia, specifically in packages/keybindings. Look for how 'ctrl+k' and 'ctrlcmd+k' are defined and handled on Windows. The collision occurs in the terminalActive context. Check if the platform specific key mapping is causing the conflict, and consider adding a platform conditional or adjusting the keybindings. Review the error message logic in generateKeybindings.ts or similar files.