eclipse-theia/theia

[plugin] Cannot read property 'subscriptions' of undefined

Open

#5,626 建立於 2019年7月3日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
bughelp wantedplug-in system

描述

I can reproduce it with https://github.com/sstone1/che-plugin-registry/releases/download/0.0.1/ibm-blockchain-platform-1.0.3.vsix

root ERROR [hosted-plugin: 1970] (node:1970) UnhandledPromiseRejectionWarning: TypeError: Cannot read property 'subscriptions' of undefined
    at disposeExtension (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:319:13)
    at ActivatedPlugin.<anonymous> (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:209:9)
    at Generator.next (<anonymous>)
    at fulfilled (/tmp/vscode-unpacked/ibm-blockchain-platform-1.0.3.vsix/extension/out/src/extension.js:17:58)
    at process._tickCallback (internal/process/next_tick.js:68:7)

It seems to happen when the window is closed.

貢獻者指南

技術棧
typescript
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
無
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
Investigate the error in the disposeExtension function at line 319 of extension.js. The error suggests that the 'subscriptions' property is undefined when attempting to dispose of a plugin upon window close. Review the plugin lifecycle code in the Theia repository, possibly in packages/plugin or similar. Consider adding a null check or ensuring subscriptions is initialized before disposal. Also check if there are any related issues or PRs.