eclipse-theia/theia

URL path escapes '@' symbol, which breaks the url

Open

#4,927 建立於 2019年4月17日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
help wanted

描述

Description

I have theia running under JupterLab, the username in the url is an email address and contains an @, for example:

/users/rayh@example.com/theia

While I can load the page, the websocket url escapes the @ and therefore breaks the url and the websocket connection cannot be established.

In webpack:///./node_modules/vscode-uri/lib/esm/index.js - if I flip skipEncoding to true, the url now works, but i suspect this will not encode the request params. image

Here is the failing connection: image

Reproduction Steps

Simplest test would be to deploy theia under a url path that contains an '@'

OS and Theia version: Theia 0.5.0 running in Ubutnu 18.04.1 LTS

貢獻者指南

技術棧
typescriptnodejs
領域
full stack
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic TypeScriptunderstanding of URL encoding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
80
研究方向
Examine the vscode uri library, specifically the file `lib/esm/index.js` where the `skipEncoding` flag is used. The issue suggests flipping it to `true` fixes the websocket URL, but may affect encoding of other request params. Investigate whether a localized fix can be applied to avoid global changes. Also look at Theia's websocket connection code to see how the URL is constructed and where the encoding occurs. Consider adding a test for URLs containing special characters like '@'.