eclipse-theia/theia

URL path escapes '@' symbol, which breaks the url

開放

#4,927 建立於 2019年4月17日

 (1 則留言) (0 個反應) (0 位負責人)TypeScript (2,478 個分叉)batch import
help wanted

倉庫指標

星標
 (18,676 顆星)
PR 合併指標
 (平均合併 15天 4小時) (30 天內合併 75 個 PR)

描述

Description

I have theia running under JupterLab, the username in the url is an email address and contains an @, for example:

/users/rayh@example.com/theia

While I can load the page, the websocket url escapes the @ and therefore breaks the url and the websocket connection cannot be established.

In webpack:///./node_modules/vscode-uri/lib/esm/index.js - if I flip skipEncoding to true, the url now works, but i suspect this will not encode the request params. image

Here is the failing connection: image

Reproduction Steps

Simplest test would be to deploy theia under a url path that contains an '@'

OS and Theia version: Theia 0.5.0 running in Ubutnu 18.04.1 LTS

貢獻者指南