eclipse-theia/theia

Workspace service does not handle updates on network drives

Open

#12,132 建立於 2023年2月1日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
help wantedworkspace

描述

Bug Description:

If I create a multiroot workspace on a network drive then Workspace service couldn't handle workspace root updates. https://github.com/eclipse-theia/theia/blob/b28c8b9d543e7df6c5d2bc524d40c50414df7e4d/packages/workspace/src/browser/workspace-service.ts#L104 "event.contains(this._workspace.resource)" Condition is always false because this._workspace.resource == "/u:/my-workspace" and event.changes[0].resource == "/userbackup/admin/my-workspace/roots.json" But u:/ and /userbackup/admin are the same drives. Nevertheless, "event.contains" check returns false

Steps to Reproduce:

  1. Create multiroot workspace on a network drive where
  2. Open ide on this workspace
  3. Edit the file containing workspace roots
  4. Workspace service couldn't handle file update

Additional Information

  • Operating System: Windows 10

貢獻者指南

技術棧
typescriptnodejs
領域
backenddesktop
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsTypeScriptFile system path handling on Windows
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
40
研究方向
The issue is in workspace service.ts at line 104 where event.contains checks URI equality but network drive paths differ (e.g., 'u:/' vs '/userbackup/admin'). Investigate how URIs are constructed on Windows and consider using fs.realpathSync or a path normalization utility. Check Theia's URI utilities for cross platform path handling.