eclipse-theia/theia

Uncaught Error: Cannot get key code from the keyboard event. Keydown event without code on chrome

Open

#10,702 建立於 2022年2月2日

在 GitHub 查看
 (11 留言) (1 反應) (0 負責人)TypeScript (18,676 star) (2,478 fork)batch import
help wantedkeybindings

描述

Bug Description:

When I click a datalist option linked to an input on Chrome (not Firefox), a keydown event is triggered. This event does not have a key/code/keycode. I don't know if it is a bug of Chrome but in any case, the widget listens keydown events and tries to find the key. Exception is thrown here. The event should probably just be ignored in this case.

This error once happened with electron but it is probably not relevant anymore

Steps to Reproduce:

  1. Create an input and link it with a datalist containing several options in Chrome.
  2. Listen for keydown events.
  3. Click an option
  4. Observe that there is no key information in the event.

Additional Information

  • Operating System: Windows 10, Chrome 97
  • Theia Version: Last, 1.22 (browser)

貢獻者指南

技術棧
typescript
領域
frontend
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
active
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
TypeScriptkeyboard eventsChrome browser
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
75
研究方向
The error occurs in packages/core/src/common/keys.ts around line 390. When a keydown event lacks a key code (as happens with Chrome's datalist interaction), an uncaught error is thrown. The fix is to add a check to ignore such events. Refer to issue #8157 for prior Electron context. Testing should involve creating an input with a datalist in Chrome and verifying no exception is thrown.
Uncaught Error: Cannot get key code from the keyboard event. Keydown event without code on chrome · eclipse-theia/theia#10702 | Good First Issue