dthree/vorpal

.catch should not trigger on a command group

Open

#64 建立於 2015年12月21日

在 GitHub 查看
 (2 留言) (1 反應) (0 負責人)JavaScript (5,609 star) (313 fork)batch import
bughelp wanted

描述

when not implementing a catch hook, typing in a command of a group gives you the help for it's subcommands.

if however you implement a catch hook, the catch hook is triggered instead.

I think it would still be useful to show the help for a command group, instead of triggering the catch.

貢獻者指南

技術棧
javascriptnodejs
領域
cli
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Node.jsbasic Vorpal knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine Vorpal's command group and catch hook logic in the source code (likely in lib/command.js). Understand how the library distinguishes between a command group and a regular command. The current behavior triggers catch when a group is invoked; the expected behavior is to show help for the group. Modify the command execution flow to skip catch for command groups and instead display help.