downshift-js/downshift

Have `Home`/`End` keys change cursor position, not selected item

Open

#1,162 建立於 2020年8月25日

在 GitHub 查看
 (9 留言) (6 反應) (0 負責人)JavaScript (11,761 star) (980 fork)batch import
enhancementhelp wanted

描述

Downshift (useComboBox) is set up for Home and End keys to select the first or last option in the dropdown. However, the WAI-ARIA ListBox spec suggests that those keys should have their normal behavior of moving the cursor to the beginning/end of the text input.

貢獻者指南

技術棧
javascriptreact
領域
frontendaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
mostly clear
前置要求
familiarity with React hooksunderstanding of combobox accessibility
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the useCombobox hook in downshift, particularly the keydown event handler for Home and End keys. The current behavior selects the first/last item, but the WAI ARIA spec expects cursor movement in the input. Look at the code in src/hooks/useCombobox/ and identify where key events are dispatched. The fix likely involves changing the default behavior of those keys to not call selectItem but rather move cursor. Ensure existing tests are updated accordingly.