downshift-js/downshift

TypeScript: have items and selectedItems as Readonly

Open

#1,030 建立於 2020年4月30日

在 GitHub 查看
 (4 留言) (1 反應) (0 負責人)JavaScript (11,761 star) (980 fork)batch import
TypeScripthelp wanted

描述

  • downshift version:
  • node version:
  • npm (or yarn) version:

Relevant code or config

What you did:

What happened:

Reproduction repository:

Problem description: Since we use items/selectedItems just for some logic and we do not tamper with them, we can mark them as read only in the TS interface.

Suggested solution: In typings.ts for useSelect, useCombobox and useMultipleSelection, use Readonly to wrap the items type.

貢獻者指南

技術棧
typescriptreact
領域
frontend
議題類型
feature
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic TypeScript knowledgeFamiliarity with downshift typings
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Locate typings.ts file in the downshift source code. For hooks useSelect, useCombobox, and useMultipleSelection, modify the type definitions to wrap the items and selectedItems properties with Readonly<T> to indicate they are not mutated. Ensure consistency across all three hooks. No logic changes required.