dotnet/winforms

DataGridView not dispose old elements

開放

#6,859 建立於 2022年3月17日

 (11 則留言) (0 個反應) (0 位負責人)C# (922 個分叉)batch import
area-controls-DataGridViewhelp wantedtenet-performance

倉庫指標

星標
 (4,100 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

  • .NET Core Version: all up to 7.0 p2

  • Have you experienced this same bug with .NET Framework?: Yes

Problem description: As I mentioned in https://github.com/dotnet/winforms/issues/6858 DataGridView not dispose old data on DataSource change. This is lead to 2 problems:

  1. All this stuff are going to finalization query because we have unnecessary finalizer here #6858.
  2. If we have a ContextMenuStrip bound to Cell/Column/Row we will have a memory leak. DataGridView with 3 columns and ContextMenuStrip bound to 1000 rows, result of DS refresh: image

Expected behavior: Old data must be property disposed. Probably in DataGridView.RefreshColumnsAndRows() (in DataGridView.Methods.cs)

Minimal repro: DataGridViewLeak.zip

貢獻者指南