dotnet/winforms

[Dark Mode] Indeterminate CheckState icon barely visible

Open

#11,933 建立於 2024年8月20日

在 GitHub 查看
 (1 留言) (0 反應) (1 負責人)C# (4,100 star) (922 fork)batch import
area-DarkModehelp wanted

描述

.NET version

9.0.0-rc.1.24418.2 + build private dll from winforms repo main branch

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

This is a new feature Dark Mode: https://github.com/dotnet/winforms/pull/11857

Issue description

The indeterminate check state icon is barely visible in Dark Mode. Controls affected are ContextMenuStrip, MenuStrip, StatusStrip DropDownButton and ToolStrip DropDownButton

Dark Mode Screenshot 2024-08-20 134113 (1)

Classic Mode Screenshot 2024-08-20 134353 (1)

Steps to reproduce

  1. Create a WinForms project
  2. Add a ContextMenuStrip to the form
  3. Add a toolStripMenuItem to the ContextMenuStrip
  4. Change the property of the toolStripMenuItem as below
  • Checked : True
  • CheckState : Indeterminate
  1. Set form ContextMenuStrip property to contextMenuStrip1
  2. Run the project and observe the indeterminate Checkstate icon

貢獻者指南

技術棧
csharp
領域
desktopaccessibility
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
2
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
blocked
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#Windows Forms painting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Review the dark mode implementation in PR #11857, specifically the rendering of indeterminate check state icons in ContextMenuStrip, MenuStrip, StatusStrip DropDownButton, and ToolStrip DropDownButton. Examine the CheckState painting code in the relevant control renderer files. Adjust the icon colors to ensure sufficient contrast in dark mode.