dotnet/tye

Exit code not properly logged in error message

Open

#1,138 建立於 2021年8月4日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C# (5,310 star) (532 fork)batch import
buggood first issue

描述

Describe the bug

If a watched replica exits due to a non-zero exit code, Tye logs an error message but does not properly include the exit code.

To Reproduce

  1. Start a Tye application in "watch" mode.
  2. Kill one of the replica processes.
  3. Note watch: Exited with error code Microsoft.Tye.ProcessResult message.

Further technical details

The bug is here; only the ExitCode property should be logged, not the whole ProcessResult.

貢獻者指南

技術棧
csharp
領域
clideveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic C# knowledge
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
95
研究方向
The issue is clear and directly points to the bug location at src/Microsoft.Tye.Hosting/Watch/DotNetWatcher.cs line 76. The fix is to change the logging statement to output only the ExitCode property of ProcessResult instead of the entire object. No further investigation is needed.
Exit code not properly logged in error message · dotnet/tye#1138 | Good First Issue