dotnet/runtime

Simplify JIT-EE interface modification

Open

#76,184 建立於 2022年9月26日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C# (5,445 fork)batch import
area-CodeGen-coreclrhelp wanted

倉庫指標

Star
 (17,886 star)
PR 合併指標
 (平均合併 12天 11小時) (30 天內合併 661 個 PR)

描述

Despite the fact it was partially automated in the past it's still quite exhausting to add new APIs, I propose to address at least these issues:

  • Autogenerate corinfo.h (e.g. introduce corinfo_generated.h) part from ThunkInput.txt - we can move comments to ThunkInput.txt
  • Autogenerate superpmi-shim-simple\icorjitinfo.cpp
  • Autogenerate superpmi-shim-collector\icorjitinfo.cpp
  • Append _generated.h to all auto-generated files (currently there are still like 5 or 6 auto-generated files without them - it helps to ignore them when adding a new API) - https://github.com/dotnet/runtime/pull/77083
  • gen.bat emits two new-lines in the end of CorInfoBase.cs breaking compilation - https://github.com/dotnet/runtime/pull/77083
  • Ensure gen.bat is no-op on unchanged codebase on CI

category:cq theme:jit-ee-interface skill-level:beginner cost:small impact:small

貢獻者指南