倉庫指標
- Star
- (17,886 star)
- PR 合併指標
- (平均合併 12天 11小時) (30 天內合併 661 個 PR)
描述
<ProductVersion /> is defined centrally in the Versions.props file and is currently set to 6.0.0: https://github.com/dotnet/runtime/blob/54f6250216a8f73025ccd3340560f26455b3ec18/eng/Versions.props#L3-L4
In addition to that, installer defines the <ProductVersion /> property as well which means the central one is overwritten: https://github.com/dotnet/runtime/blob/54f6250216a8f73025ccd3340560f26455b3ec18/src/installer/Directory.Build.targets#L42
The Arcade SDK itself doesn't know anything about <ProductVersion /> but the Installers package in Arcade does, i.e.: https://github.com/dotnet/arcade/blob/55c2f07346757ddc6f1fa569b2de6506b3fdea2a/src/Microsoft.DotNet.Build.Tasks.Installers/build/bundle.targets#L151
We should clarify which of the the property values the Installers package in Arcade expects (my guess is the one provided by the installer subset) and possibly depend on a different on a different property in that package. In addition to that my assumption is that more of the properties next to <ProductVersion /> in the installers subset can be cleaned-up and consolidated with the rest of the repo and don't need to reside inside a target anymore.
Related: https://github.com/dotnet/runtime/issues/48229
cc @dotnet/runtime-infrastructure