dotnet/runtime

[mono] MonoImage->references reads should be atomic

Open

#32,889 建立於 2020年2月26日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C# (5,445 fork)batch import
area-VM-meta-monogood first issueruntime-mono

倉庫指標

Star
 (17,886 star)
PR 合併指標
 (平均合併 12天 11小時) (30 天內合併 661 個 PR)

描述

As of https://github.com/dotnet/runtime/pull/32622 we will take the image lock when writing to references, but reads throughout the code are currently done directly and without locking. This should be changed to use accessor functions that read in the pointer atomically.

This isn't time-critical as I don't believe we've seen many (any?) crashes related to this, but is worth noting and changing for completeness' sake.

貢獻者指南