dotnet/runtime

Facades and NotSupported assemblies are bloated with resources they don't use

開放

#28,888 建立於 2019年3月6日

 (9 則留言) (2 個反應) (0 位負責人)C# (5,445 個分叉)batch import
area-Infrastructure-librariesenhancementhelp wanted

倉庫指標

星標
 (17,886 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Often times we have builds that cross-compile and have very different implementations. Our resource conventions don't force folks to think about this, so the resources are often a superset of all configurations.

We should change the defaults so that this isn't the case.

I propose the following:

  1. By default PartialFacades should not include any resources, unless a project opts-in. Folks should discover this relatively easily as SR.Foo will fail to work in the partial source. They can fix it by setting a flag and potentially providing specific resources for that build of the library.
  2. By default NotSupported assemblies require a unique resx. We can change the path convention to something like Resources\NotSupported.resx instead of strings.resx

Across all our builds this will save over a MB of unused resources.

貢獻者指南