dotnet/runtime

Properly factor DllImports into Common\src\Interop

開放

#28,035 建立於 2018年11月30日

 (23 則留言) (0 個反應) (0 位負責人)C# (5,445 個分叉)batch import
area-Metaenhancementgood first issuehelp wantedtracking

倉庫指標

星標
 (17,886 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

We now have a bunch of libraries with their own DllImports, whereas the expected approach is that all DllImports in product src should be included from src\Common\src\Interop, appropriately factored by platform and library, and then those source files included into the relevant assemblies that need them.

  • Microsoft.Diagnostics.Tracing.EventSource.Redist
  • System.Data.SqlClient
  • System.Diagnostics.EventLog
  • System.DirectoryServices
  • System.DirectoryServices.AccountManagement
  • System.DirectoryServices.Protocols
  • System.Drawing.Common
  • System.IO.Compression
  • System.IO.Compression.Brotli
  • System.IO.Ports
  • System.Management
  • System.Reflection.Metadata
  • System.Runtime.Caching
  • System.Security.Cryptography.Csp
  • System.Security.Cryptography.Pkcs
  • System.Security.Cryptography.X509Certificates

This all needs to be refactored and dedup'd.

https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/interop-guidelines.md

貢獻者指南