dotnet/runtime

MetadataLoadContext assembly binding behavior is documented incorrectly

Open

#113,353 建立於 2025年3月11日

在 GitHub 查看
 (2 留言) (0 反應) (0 負責人)C# (17,886 star) (5,445 fork)batch import
area-System.Reflectiondocumentationhelp wanted

描述

When MetadataLoadContext is resolving an assembly and its MetadataAssemblyResolver returns null, it throws an exception with this message: https://github.com/dotnet/runtime/blob/a49ed697037bad503e32daa23f4339ebfb8962ea/src/libraries/System.Reflection.MetadataLoadContext/src/Resources/Strings.resx#L181 The message suggests that 'pre-loading' the assembly with LoadFromAssemblyPath will populate the MetadataLoadContext's assembly binding cache.

The API documentation for the LoadFrom methods also suggests this is the case:

MetadataLoadContext.LoadFromAssemblyPath Loads an assembly from a specific path on the disk and binds its assembly name to it in the MetadataLoadContext.

But these methods do not do this: https://github.com/dotnet/runtime/blob/a49ed697037bad503e32daa23f4339ebfb8962ea/src/libraries/System.Reflection.MetadataLoadContext/src/System/Reflection/MetadataLoadContext.Loading.cs#L47-L49

It looks like this behavior was changed, but the documentation and exception message was not updated: https://github.com/dotnet/runtime/commit/2ef74f6be9ac1a70902facdc4047c49682e75005#diff-7a38392b94b0c17ee62172e5b642b77f0b3a1bb8d79a6488d24f1729345c46fbL49

貢獻者指南

技術棧
csharp
領域
documentation
議題類型
documentation
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
basic understanding of MetadataLoadContext
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
The issue identifies that the exception message in Strings.resx (line 181) and the API documentation for LoadFromAssemblyPath incorrectly suggest that pre loading an assembly populates a binding cache. The actual behavior is shown in MetadataLoadContext.Loading.cs lines 47-49. The change in commit 2ef74f6be9ac1a70902facdc4047c49682e75005 removed that caching behavior. The fix involves updating the exception message in Strings.resx and the documentation comments for LoadFrom methods to reflect that they do not cache bindings.