dotnet/roslyn

Fix cascading diagnostics when using invalid crypto options with PublicSign

Open

#9,198 建立於 2016年2月25日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugConcept-Diagnostic ClarityFeature Requesthelp wanted

描述

For instance, see PublicSignWithRelativeKeyPath in CompilationAPITests.vb.

There are two errors:

BC2014: the value 'test.snk' is invalid for option 'CryptoKeyFile'
+BC37254: Public sign was specified and requires a public key, but no public key was specified

In this case, only the first error is really necessary. This is true for almost any set of incompatible crypto options with public sign, including using CryptoKeyContainer or any set of mutually incompatible options.

See https://github.com/dotnet/roslyn/pull/9130 for the full set of diagnostics produced by incompatible options.

貢獻者指南

技術棧
csharp
領域
backendtooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C# basicscompiler diagnostics understanding
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Examine the test `PublicSignWithRelativeKeyPath` in `CompilationAPITests.vb` to understand the current cascading behavior. Look at the diagnostics produced by incompatible crypto options as listed in PR #9130. The goal is to suppress the secondary error (BC37254) when the primary error (BC2014) is already reported. Changes will likely involve the diagnostic reporting logic for crypto options in the VB compiler.