dotnet/roslyn

Clarify diagnostic when constant pattern has non-constant conversion to input type

已關閉

#63,476 建立於 2022年8月18日

 (1 則留言) (0 個反應) (0 位負責人)C# (4,257 個分叉)batch import
Area-CompilersBugConcept-Diagnostic Clarityhelp wanted

倉庫指標

星標
 (20,414 顆星)
PR 合併指標
 (平均合併 6天 17小時) (30 天內合併 256 個 PR)

描述

The error given for the below scenario could be made more clear: it is not the string literal itself which is the problem, it is the conversion to the switch input type which makes it a problem. SharpLab.

Discussed in https://github.com/dotnet/roslyn/discussions/63400

Originally posted by zms9110750 August 15, 2022

foreach (var ele in XElement.Load("D:\\temp.xml").Nodes())
{
	switch (ele)
	{
		case XElement xel:
			const string br = "br";
			Console.WriteLine(xel.Name switch
			{
				"br" => "\n", //CS0150
				br => "\n",	  //CS0150
				S.br => "\n", //CS0150
			});
			break;

		case XText txt:
			Console.WriteLine(txt);
			break;
	}
}
static class S
{
	public const string br = "br";
}

Why does pattern matching not treat strings as constants

貢獻者指南