dotnet/roslyn

EnC: disallow editing async methods with incompatible constraints on their method builders

開放

#51,234 建立於 2021年2月15日

 (0 則留言) (0 個反應) (0 位負責人)C# (4,257 個分叉)batch import
Area-InteractiveConcept-Continuous ImprovementInteractive-EnChelp wanted

倉庫指標

星標
 (20,414 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Follow up on discussion: https://github.com/dotnet/roslyn/discussions/51189

In debug builds we emit async state machine types as classes so that we can add fields to them as needed during EnC. Emitting the state machine type as reference type instead of a value type might however conflict with a constraint:

If

  1. the return type of an async method specifies a custom builder B via AsyncMethodBuilder, and
  2. B.Start<TStateMachine>(ref TStateMachine), B.AwaitOnCompleted<TAwaiter, TStateMachine>(ref TAwaiter awaiter, ref TStateMachine stateMachine), or B.AwaitUnsafeOnCompleted<TAwaiter, TStateMachine>(ref TAwaiter awaiter, ref TStateMachine stateMachine) have a constraint on TStateMachine that disallows it to be a reference type.

Fix: The compiler should identify these cases and keep the state machine type as struct. The IDE should disallow editing such async methods.

貢獻者指南