dotnet/roslyn

'IDE0031 Use null propagation' incorrectly suggested for LINQ expression with left join (DefaultIfEmpty)

開放

#47,788 建立於 2020年9月17日

 (1 則留言) (1 個反應) (0 位負責人)C# (4,257 個分叉)batch import
Area-CompilersBugFeature - IDE0031IDE-CodeStylehelp wanted

倉庫指標

星標
 (20,414 顆星)
PR 合併指標
 (平均合併 6天 17小時) (30 天內合併 256 個 PR)

描述

[Update: IDE issue was traced to a problem with the GetSymbolInfo Compiler API, in part. See details below. May relate to another issue with visitors on this LINQ query]

Version Used: 16.7.3

The motivating situation that led to me filing https://github.com/dotnet/roslyn/issues/33992 was not covered by the fix for the minimal repro I gave in that issue.

Using the standard LINQ left outer join pattern:

_ = from itemA in new[] { new { X = (int?)1 } }.AsQueryable()
    join itemB in new[] { new { X = (int?)2 } }.AsQueryable() on itemA.X equals itemB.X into itemBGroup
    from itemB in itemBGroup.DefaultIfEmpty()
    //     ↓ IDE0031 Use null propagation
    select itemB == null ? null : itemB.X;

After applying the suggested fix:

_ = from itemA in new[] { new { X = (int?)1 } }.AsQueryable()
    join itemB in new[] { new { X = (int?)2 } }.AsQueryable() on itemA.X equals itemB.X into itemBGroup
    from itemB in itemBGroup.DefaultIfEmpty()
    //     ↓↓↓↓↓↓↓↓ CS8072 An expression tree lambda may not contain a null propagating operator.
    select itemB?.X;

/cc @CyrusNajmabadi

貢獻者指南