dotnet/roslyn

Change signature does not handle errors at call sites well

開放

#46,456 建立於 2020年7月30日

 (0 則留言) (0 個反應) (0 位負責人)C# (4,257 個分叉)batch import
Area-IDEBughelp wanted

倉庫指標

星標
 (20,414 顆星)
PR 合併指標
 (PR 指標待抓取)

描述

Version Used: Version 16.8.0 Preview 2.0 [30327.8.master]

Steps to Reproduce:

  1. Checkout Roslyn at a7976180954969c9904ee6d449adad28283ddc34
  2. Open src\Features\Core\Portable\SolutionCrawler\WorkCoordinator.WorkItem.cs and find WorkItem constructor on line 95
  3. Remove bool isLowPriority parameter using Change signature refactoring.
  4. Notice isLowPairority argument is now squiggled as expected. image
  5. Without fixing the error, use Change signature refactoring to remove bool isLowPriority parameter from the constructor on line 100.
  6. Review changes: image

Notice invocationReasons and retry: false were removed.

貢獻者指南