dotnet/roslyn

Extract method does not respect whitespace when extracting a return statement

Open

#40,023 建立於 2019年11月26日

在 GitHub 查看
 (0 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBugFeature - Extract Methodhelp wanted

描述

Version Used: 16.4.0 P6

Steps to Reproduce:

  1. Highlight a single return statement
  2. Ctrl+. and select extract method code action

Expected Behavior: Newline above return statement preserved

Actual Behavior: Newline not preserved. Seems to be an edge case since extracting regular statements seems to correctly preserve the newline if present.

newlinenotrespected

貢獻者指南

技術棧
csharp
領域
toolingdeveloper experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C#Roslyn syntax treescode refactoring concepts
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
60
研究方向
Investigate the ExtractMethod refactoring in Roslyn (likely under src/Features/Core/Portable/ExtractMethod/). Look at how the method generates the extracted method and call site, particularly how it handles whitespace before return statements. The issue suggests that for regular statements newline is preserved but for return statements it's not. Check the logic that inserts trivia (whitespace) when constructing the new method body. You may need to trace the code flow from the code action invocation to the syntax generation step.