dotnet/roslyn

Extract interface doesn't respect insert_final_newline editorconfig

Open

#33,868 建立於 2019年3月5日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBugFeature - Editor ConfigFeature - Extract InterfaceIDE-CodeStylehelp wanted

描述

Version Used: 15.9

Steps to Reproduce:

  1. Run with insert_final_newline=true editorconfig
  2. Run the "Extract Interface" code fix
  3. Look at the generated file

Expected Behavior: The last character(s) are a line break

Actual Behavior: The last character in the file is the closing curly brace of the namespace and git says "No newline at end of file"

貢獻者指南

技術棧
csharp
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic C# knowledgeUnderstanding of editorconfig
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
50
研究方向
Look into the Extract Interface code fix within the Roslyn codebase, likely in src/Features/ExtractInterface. Investigate how editorconfig settings like insert final newline are applied to generated code. Check other code fixes for consistency, e.g., in CSharpCodeGenerationOptions. The fix should ensure a newline is appended at the end of the generated file.