dotnet/roslyn

VB boolean literals not highlighted as keywords in SymbolDisplay.ToDisplayParts

Open

#30,960 建立於 2018年11月5日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
4 - In ReviewArea-CompilersBughelp wanted

描述

Create a C# project and a VB project referencing it. C# file:

public class CS
{
    public const bool Const = true;
}

VB with completion invoked at |.

Module VB
    Sub M()
        CS.|
    End Sub
End Module

image Expected behavior: True is colored as a keyword Actual behavior: it's not

This is because in the result of calling SymbolDisplay.ToDisplayParts on the field, the part with the true keyword has a kind of SymbolDisplayPartKind.NumericLiteral as opposed to SymbolDisplayPartKind.Keyword (so this bug is in the compiler).

貢獻者指南

技術棧
csharp
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-3 hours
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C# compiler internalsSymbolDisplay API
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
30
研究方向
Examine the SymbolDisplay.ToDisplayParts method in the Roslyn compiler source code. The bug is that for VB boolean literals like 'True', the part kind is incorrectly set to NumericLiteral instead of Keyword. Focus on the code that determines the kind for constant values, likely in semantic model or display utilities. The issue has a clear reproduction and expected behavior, so a fix would involve updating the condition that assigns the kind for boolean constants.