dotnet/roslyn

Should protected abstract methods in SemanticModel be private protected instead?

開放

#29,235 建立於 2018年8月12日

 (0 則留言) (0 個反應) (0 位負責人)C# (4,257 個分叉)batch import
Area-CompilersBugConcept-APIhelp wanted

倉庫指標

星標
 (20,414 顆星)
PR 合併指標
 (平均合併 6天 17小時) (30 天內合併 256 個 PR)

描述

I noticed that protected abstract methods on SemanticModel like GetDeclaredSymbolCore are documented in Roslyn's API reference. Since it's impossible to inherit from SemanticModel for users of the API, I think such methods should not be included in the API reference.

And I think the most reasonable way to do that is to change such methods to private protected. Do you agree?

It's possible there are more types like that in the codebase, but SemanticModel is the one where I noticed this.

貢獻者指南