dotnet/roslyn

Visual Studio only formats if/while(...) when contents of (...) requires formatting

Open

#21,138 建立於 2017年7月26日

在 GitHub 查看
 (15 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBugIDE-Formatterhelp wanted

描述

Version Used:

Visual Studio 2015 - 2017 (15.2)

Steps to Reproduce:

  1. Enter if(true == false){ or while(true == false){ in the Visual Studio editor.

Expected Behavior:

I'd expect this to be formatted to while (true == false) { }.

Actual Behavior:

It is actually formatted to while(true == false) { }. (note the missing after the while(.

If you enter while(true==false){, it gets formatted to while (true == false) { as I'd expect. if(true){ also becomes if (true) {.

It's actually different with for(var x=0;x<10;x++){, which becomes for(var x = 0; x < 10; x++) { }. In this case no is inserted in the for( despite the contents of (...) being formatted.

image

Because this behavior is inconsistent between (true) and (true == false), I'm constantly getting tripped up by it. 😭

See Twitter thread here: https://twitter.com/jcansdale/status/890186489912545282

貢獻者指南

技術棧
csharp
領域
developer experience
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
3
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
1-2 days
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
Basic knowledge of C#Familiarity with Roslyn's syntax formatting
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the formatting logic for control flow statements (if, while, for) in the Roslyn codebase. Focus on the token insertion mechanism that adds a space between the keyword and the opening parenthesis. Look at the SyntaxFormatter or related classes in the Formatting directory. Identify why a space is inserted only when the condition content requires formatting (e.g., contains operators like '=='), but not for simple literal conditions. Also examine the for loop case where no space is inserted after 'for' despite the condition being formatted. Compare the handling of 'if', 'while', and 'for' to understand the inconsistency.