dotnet/roslyn

SyntaxGenerator removes DisabledTextTrivia even with "KeepDirectives" is specified

Open

#21,122 建立於 2017年7月25日

在 GitHub 查看
 (1 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-IDEBughelp wanted

描述

Consider the following code:

#if SomethingNotSet
    this is disabled code
#endif

    SomeCode();

If you use SyntaxGenerator to remove the "SomeCode();" statement and you specify that you want to keep leading directives, you get the following:

#if SomethingNotSet
#endif

This seems pretty broken. Keeping directives is so that the directives will not be touched and the code will retain its meaning. Here though we remove the DisabledText breaking the intent.

貢獻者指南

技術棧
csharp
領域
tooling
議題類型
bug
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
4
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
half day
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
stale
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
C# preprocessor directivesRoslyn SyntaxGeneratorTrivia handling
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
25
研究方向
Investigate the SyntaxGenerator class to understand how disabled text trivia is handled when KeepDirectives option is used. The issue provides a minimal repro: removing a statement with leading directives causes disabled text to be stripped. Look at the methods related to directive trivia in SyntaxGenerator, and consider adding logic to preserve DisabledTextTrivia when KeepDirectives is specified.