dotnet/roslyn

Always true condition in LocalRewriter_Conversion.cs

Open

#17,839 建立於 2017年3月14日

在 GitHub 查看
 (3 留言) (0 反應) (0 負責人)C# (20,414 star) (4,257 fork)batch import
Area-CompilersBugConcept-Design Debthelp wanted

描述

Hi there,

On the latest code, the line 23 of LocalRewriter_Conversion.cs contains one bit (&& !wasInExpressionLambda) which is always true and so can be safely removed. Indeed because of the short-circuit if the right part of the expression is reached that means that wasInExpressionLambda is false so !wasInExpressionLambda is always true.

貢獻者指南

技術棧
csharp
領域
backend
議題類型
refactor
難度面向新貢獻者的預計實作難度，1 表示很小改動，5 表示專家級工作。
1
預計時間有經驗貢獻者完成調查、實作、測試並準備 pull request 的粗略時間範圍。
under 1 hour
活動狀態議題目前的可參與程度：新鮮、活躍、陳舊、阻塞或等待維護者輸入。
fresh
清晰度議題是否清楚說明預期改動、驗收標準和下一步。
clear
前置要求
familiarity with C#basic understanding of boolean logic
新手友善度1-100 的估計分數，表示該議題對首次貢獻者的友善程度。
90
研究方向
Locate the file `src/Compilers/CSharp/Portable/Lowering/LocalRewriter/LocalRewriter Conversion.cs` in the roslyn repository. At line 23, there is a condition `&& !wasInExpressionLambda` that is always true when reached due to short circuit evaluation. Remove the redundant `&& !wasInExpressionLambda` part, ensuring the logic remains equivalent. No other changes required.